alexeyinkin commented on code in PR #26630:
URL: https://github.com/apache/beam/pull/26630#discussion_r1191096910
##########
learning/tour-of-beam/frontend/lib/pages/tour/controllers/content_tree.dart:
##########
@@ -60,15 +63,20 @@ class ContentTreeController extends ChangeNotifier {
_onParentNodePressed(node);
} else if (node is UnitModel) {
if (node != _currentNode) {
- _currentNode = node;
+ _setUnit(node);
}
}
if (_currentNode != null) {
- _treeIds = _getNodeAncestors(_currentNode!, [_currentNode!.id]);
+ _breadcrumbIds = _getNodeAncestors(_currentNode!, [_currentNode!.id]);
}
Review Comment:
Should this also go to `_setUnit()`?
##########
learning/tour-of-beam/frontend/lib/models/parent_node.dart:
##########
@@ -19,6 +19,7 @@
import 'package:collection/collection.dart';
import 'node.dart';
+import 'unit.dart';
abstract class ParentNodeModel extends NodeModel {
Review Comment:
```suggestion
abstract class ParentNodeModel<T extends NodeModel> extends NodeModel {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
