clayburn commented on code in PR #26351:
URL: https://github.com/apache/beam/pull/26351#discussion_r1191684912


##########
settings.gradle.kts:
##########
@@ -15,34 +15,45 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-
+import 
com.gradle.enterprise.gradleplugin.internal.extension.BuildScanExtensionWithHiddenFeatures
 
 plugins {
-  id("com.gradle.enterprise") version "3.4.1" apply false
+  id("com.gradle.enterprise") version "3.13.2"
+  id("com.gradle.common-custom-user-data-gradle-plugin") version "1.10"
 }
 
 
-// Plugins which require online access should not be enabled when running in 
offline mode.
-if (!gradle.startParameter.isOffline) {

Review Comment:
   The build scam publishing is implicitly disabled when offline is passed. So 
the check is not needed and omitting it can simplify your build scripts



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to