johnjcasey commented on code in PR #26746:
URL: https://github.com/apache/beam/pull/26746#discussion_r1197003992
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileBasedSource.java:
##########
@@ -91,6 +94,7 @@ protected FileBasedSource(
this.mode = Mode.FILEPATTERN;
this.emptyMatchTreatment = emptyMatchTreatment;
this.fileOrPatternSpec = fileOrPatternSpec;
+ this.filesSizeBytes = new AtomicReference<>();
Review Comment:
Is this a file resource level cache?
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileBasedSource.java:
##########
@@ -73,6 +74,8 @@
private MatchResult.@Nullable Metadata singleFileMetadata;
private final Mode mode;
+ private final AtomicReference<@Nullable Long> filesSizeBytes;
Review Comment:
Can we add a test case for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
