damccorm commented on code in PR #26690:
URL: https://github.com/apache/beam/pull/26690#discussion_r1197863929
##########
sdks/python/setup.py:
##########
@@ -334,11 +334,13 @@ def get_portability_package_data():
# https://github.com/jupyter/jupyter_client/issues/637
'jupyter-client>=6.1.11,!=6.1.13,<8.1.1',
'timeloop>=1.0.2,<2',
+ 'nbformat>=5.0.5',
+ 'nbconvert>=6.2.0',
] + dataframe_dependency,
'interactive_test': [
# notebok utils
- 'nbformat>=5.0.5,<6',
- 'nbconvert>=6.2.0,<8',
+ 'nbformat>=5.0.5',
Review Comment:
It looks like the most recently released versions of these packages are
within the specified bounds (https://pypi.org/project/nbformat/ and
https://pypi.org/project/nbconvert/), so I think there might be a mistake there?
Note that we shouldn't remove the upper bound entirely regardless, if we
need to bump it up we can. The goal of these upper bounds is to keep new
dependencies from breaking old versions of the sdk (basically the flow of:
1. We release beam 2.X.0 which depends on Y>=Z.0.0
2. Y releases Z+1.0.0 which is somehow incompatible with beam 2.X.0
3. We don't have a great way of patching beam 2.X.0, so all new
installations fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
