Abacn commented on code in PR #26752:
URL: https://github.com/apache/beam/pull/26752#discussion_r1198074155
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiWriteUnshardedRecords.java:
##########
@@ -691,7 +691,7 @@ void postFlush() {
@Nullable
TableSchema updatedTableSchema =
Review Comment:
wait, we actually can only request for updatedTableSchema if
autoUpdateSchema, that is include
```
TableSchema updatedTableSchema =
(streamAppendClient != null) ?
streamAppendClient.getUpdatedSchema() : null;
if (updatedTableSchema != null) {
invalidateWriteStream();
appendClientInfo =
Preconditions.checkStateNotNull(getAppendClientInfo(false,
updatedTableSchema));
}
```
in an if block.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
