lostluck opened a new pull request, #26782:
URL: https://github.com/apache/beam/pull/26782
DO NOT MERGE: Still need unit tests for the ParDo.processTimers method.
-------
Cleanup and fit & finish work for Go SDK timers.
* Adds a timers.Context for providing the Family & Tag fields.
* Adds a ClearTag method to EventTime and ProcessingTime timers to support
clearing a timer for a specific tag.
* Updates the timer_wordcap example
* Use a finite Periodic sequence to get elements.
* Demonstrate element batching with State & Timers.
* Add verbose logging to clarify execution for example purposes.
* Demonstrate multiple tags set for the same timer.
* Simplifies user key coderID sourcing by moving it entirely to pipeline
serialization time.
* Current Beam model is more general on timer key and window coders, but
they are implicitly associated directly with the DoFn's parallel input key.
* Fetches coders at execution time from the bundle descriptors returned
timer_family_spec.
* This avoids relying on the previous implementation detail, while also
allowing the runner to replace the user key coder as needed, such as to add
length prefixes or similar.
* Handle inserted timers similarly to [Java
SDK](https://github.com/apache/beam/blob/f154d0165d31068f9e0d2ae008d7823dcf4cf53a/sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java#L1667-L1734)
allowing for quickly re-looping timers when applicable.
* Supporting this is the bulk of the PRs complexity, but ordering is
required for correctness and avoiding double firing.
* Ensure keys are not repeatedly encoded/decoded for a given inline process.
* Key bytes on fired timers are re-used when writing new timers.
* Removes unnecessary UserTimerAdapter interface, as all uses are in the
exec package.
* Ensures all timers from a given timer batch are parsed.
* Since they don't have mutable state, made timers.ProcessingTime and
timers.EventTime have value receivers instead of pointer receivers.
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example:
`addresses #123`), if applicable. This will automatically add a link to the
pull request in the issue. If you would like the issue to automatically close
on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more
tips on [how to make review process
smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit
[https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more
information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
