BjornPrime commented on code in PR #25965: URL: https://github.com/apache/beam/pull/25965#discussion_r1199261722
########## sdks/python/apache_beam/internal/gcp/auth.py: ########## @@ -119,7 +122,7 @@ class _Credentials(object): @classmethod def get_service_credentials(cls, pipeline_options): - # type: (PipelineOptions) -> Optional[google.auth.credentials.Credentials] + # type: (PipelineOptions) -> Optional[_ApitoolsCredentialsAdapter] Review Comment: The return type didn't change, I just updated the type hint to be accurate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
