jgill02 opened a new pull request, #26812: URL: https://github.com/apache/beam/pull/26812
Fixes [#26316](https://github.com/apache/beam/issues/26316). In situations where there are nullable fields in an avro ocf file, previously a previous row's non-null value for a given column would be passed into a pcollection for a subsequent datum if that column was null. Added a new test case to check for this, which failed using the previous logic. Additionally, the previous avroio package was using a legacy version (2.1.0) which is ~3-4+ years old. Upgraded to the latest goavro/v2 version. Amongst other bug fixes, this release of goavro is ~3-4x faster than the previous version (as documented on the goavro github [page](https://github.com/linkedin/goavro#major-improvements-in-v2-over-v1).) I am not 100% sure if there are additional dependencies to the previous goavro package which I do not understand, in which case this PR can be scoped to solely the bug fix mentioned above as an alternative. ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead. - [ ] Update `CHANGES.md` with noteworthy changes. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier). To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md) GitHub Actions Tests Status (on master branch) ------------------------------------------------------------------------------------------------ [](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule) See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
