damccorm commented on issue #26808: URL: https://github.com/apache/beam/issues/26808#issuecomment-1557479127
I think moving the test script to the notebooks folder makes sense. That should make for a more reasonable developer workflow (run `pytest` from the same directory you added the notebook). > The other (less preferable) alternative, is to add a copy of each notebook under sdks/python/apache_beam/testing/notebooks/. This would require everyone checking in notebooks to check them into beam/examples/notebooks as well as sdks/python/apache_beam/testing/notebooks/, which could eventually lead to inconsistency issues between the two. I don't understand why this is true; do the notebooks have to be in the same folder in order to run tests on them? That seems like an fixable challenge. Regardless, I'm still +1 on the idea. Nit: I assume the title should read "Migrate `sdks/python/apache_beam/testing/**notebooks/**` ...", right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
