robertwb commented on a change in pull request #12391:
URL: https://github.com/apache/beam/pull/12391#discussion_r461870594
##########
File path:
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java
##########
@@ -2118,8 +2113,8 @@ public TimeDomain timeDomain(DoFn<InputT, OutputT> doFn) {
}
@Override
- public K key() {
- return key;
+ public Object key() {
Review comment:
It seems a regression to not return the typed key. Can OnTimerContext
still be typed (necessitating perhaps a cast here)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
