lostluck commented on PR #26442: URL: https://github.com/apache/beam/pull/26442#issuecomment-1561798008
I'll merge if the samza post commits pass. Looks fine AFAICT, though please do remember to run the various Samza PostCommits when making changes to the Samza runner core bits: Trigger phrases can be found here: https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md The post commits are there to catch accidental and non-obvious breaks, not to constitute the whole of the testing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
