tvalentyn commented on code in PR #26913:
URL: https://github.com/apache/beam/pull/26913#discussion_r1207427071
##########
sdks/python/container/piputil.go:
##########
@@ -148,8 +148,11 @@ func findBeamSdkWhl(files []string, acceptableWhlSpecs
[]string) string {
// SDK from source tarball provided in sdkSrcFile.
func installSdk(files []string, workDir string, sdkSrcFile string,
acceptableWhlSpecs []string, required bool) error {
sdkWhlFile := findBeamSdkWhl(files, acceptableWhlSpecs)
+
if sdkWhlFile != "" {
- err := pipInstallPackage(files, workDir, sdkWhlFile, false,
false, []string{"gcp"})
+ // by default, pip rejects to install wheel if same version
already installed
+ isDev := strings.Contains(sdkWhlFile, ".dev")
Review Comment:
> though it seems PostCommit test still not run with sibling worker
hmmm... batch tests running on more than 1 core machines, should use sibling
workers. if you have a job id, I can take a look why it's not used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
