alexeyinkin commented on code in PR #26932:
URL: https://github.com/apache/beam/pull/26932#discussion_r1209767309
##########
playground/frontend/playground_components/lib/src/controllers/example_loaders/examples_loader.dart:
##########
@@ -70,6 +76,7 @@ class ExamplesLoader {
Future<void> load(ExamplesLoadingDescriptor descriptor) async {
_descriptor = descriptor;
final loaders = descriptor.descriptors.map(_createLoader).whereNotNull();
+ print('Loaders: ' + loaders.map((e) => e.descriptor.token).join(', '));
Review Comment:
Delete.
##########
playground/frontend/playground_components/lib/src/controllers/example_loaders/examples_loader.dart:
##########
@@ -43,6 +47,8 @@ class ExamplesLoader {
PlaygroundController? _playgroundController;
ExamplesLoadingDescriptor? _descriptor;
+ static List failedToLoadExamples = List<String>.empty(growable: true);
Review Comment:
```suggestion
static final failedToLoadExamples = <String>[];
```
##########
learning/tour-of-beam/frontend/integration_test/tour_page_test.dart:
##########
@@ -1,3 +1,5 @@
+// ignore_for_file: avoid_print
Review Comment:
After license.
##########
playground/frontend/lib/main.dart:
##########
@@ -31,6 +31,7 @@ import 'l10n/l10n.dart';
import 'locator.dart';
import 'playground_app.dart';
+//temp comment
Review Comment:
Delete.
##########
playground/frontend/playground_components/lib/src/controllers/example_loaders/examples_loader.dart:
##########
@@ -147,7 +154,12 @@ class ExamplesLoader {
Example example;
try {
example = await loader.future;
- } on Exception {
+ } on MultipleExceptions catch (ex) {
+ example = Example.empty(loader.sdk ?? Sdk.java);
+ _handleLoadException(loader, ex);
+ } on Exception catch (ex) {
+ example = Example.empty(loader.sdk ?? Sdk.java);
+ _handleLoadException(loader, ex);
Review Comment:
Explain why we do not throw in one of the cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
