Abacn commented on code in PR #25965:
URL: https://github.com/apache/beam/pull/25965#discussion_r1210693813


##########
sdks/python/apache_beam/io/gcp/gcsio_integration_test.py:
##########
@@ -168,33 +139,6 @@ def _test_copy_batch(
   def test_copy_batch(self):
     self._test_copy_batch("test_copy_batch")
 
-  @pytest.mark.it_postcommit

Review Comment:
   We still need test for kms. How does kms key handled now? Is it possible to 
add postcommit test using kms for new gcsio?



##########
sdks/python/apache_beam/io/gcp/gcsio_integration_test.py:
##########
@@ -168,33 +139,6 @@ def _test_copy_batch(
   def test_copy_batch(self):
     self._test_copy_batch("test_copy_batch")
 
-  @pytest.mark.it_postcommit

Review Comment:
   We still need test for kms. How is kms key handled now? Is it possible to 
add postcommit test using kms for new gcsio?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to