BjornPrime commented on code in PR #25965:
URL: https://github.com/apache/beam/pull/25965#discussion_r1211851551
##########
sdks/python/apache_beam/io/gcp/gcsio_integration_test.py:
##########
@@ -168,33 +139,6 @@ def _test_copy_batch(
def test_copy_batch(self):
self._test_copy_batch("test_copy_batch")
- @pytest.mark.it_postcommit
Review Comment:
The GCS client handles kms automatically. The default is to use the bucket
kms for a new object in that bucket. If an object is copied from one bucket to
another, the copy will have the new bucket's kms. The only way the new GCSIO
interacts with kms (beyond retrieving keys from buckets or objects) is by
allowing it to be set on a new bucket.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
