RustedBones commented on code in PR #26320:
URL: https://github.com/apache/beam/pull/26320#discussion_r1214107843
##########
sdks/java/extensions/avro/src/main/java/org/apache/beam/sdk/extensions/avro/io/AvroIO.java:
##########
@@ -702,6 +739,16 @@ public Read<T> withBeamSchemas(boolean withBeamSchemas) {
return toBuilder().setInferBeamSchema(withBeamSchemas).build();
}
+ /** Sets a coder for the result of the read function. */
+ public Read<T> withCoder(Coder<T> coder) {
Review Comment:
As a quick win, I've updated the code to leverage the case when an
`AvroDatumFactory` is passed as reader factory.
I think as the other `AvroIO` already have a `withCoder` adding one here
just increase consistency, even if discouraged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
