BjornPrime commented on PR #25965: URL: https://github.com/apache/beam/pull/25965#issuecomment-1574060065
I'm updating `gcsio_integration_test.py` now. I don't think it needs to test kms_key since we're not really managing that anymore. In fact, I dropped it from most method signatures in GCSIO since it was marked as experimental and not necessarily backwards compatible (though given our history with "experimental" features, I'm open to revisiting that decision in order to avoid breakages). As far as performance goes, I'm not convinced it needs further investigation. The regressions we initially saw were due to the tests being non-representative of typical jobs and under more typical jobs the regression disappeared. There are improvements that could be made to our perf testing approach but I think that's a separate issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
