tvalentyn commented on code in PR #26971:
URL: https://github.com/apache/beam/pull/26971#discussion_r1214928665
##########
sdks/python/container/Dockerfile:
##########
@@ -60,6 +60,7 @@ RUN mkdir -p /usr/local/gcloud && \
curl -s -O
https://dl.google.com/dl/cloudsdk/release/google-cloud-sdk.tar.gz && \
tar -xf google-cloud-sdk.tar.gz && \
/usr/local/gcloud/google-cloud-sdk/install.sh && \
+ rm -rf /usr/local/gcloud/google-cloud-sdk/.install/.backup && \
rm google-cloud-sdk.tar.gz
Review Comment:
As @bvolpato reiterated, doing so would be suboptimal right now. Happy to
discuss in person further.
Another reason, for readability it may be better to remove relevant temp
content roughly in the same place in the code where the temp content was added.
That said, given we use pip multiple times, i sent out
https://github.com/apache/beam/pull/27006 to reduce the number of layers and
clear pip cache at the very end of the main layer .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
