johnjcasey commented on code in PR #26970:
URL: https://github.com/apache/beam/pull/26970#discussion_r1218377814
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/SpannerChangestreamsReadSchemaTransformProvider.java:
##########
@@ -193,15 +218,19 @@ public abstract static class Builder {
}
}
- private static final class DataChangeRecordToRow extends
DoFn<DataChangeRecord, Row> {
+ public static final class DataChangeRecordToRow extends
DoFn<DataChangeRecord, Row> {
Review Comment:
Also, you should create a test case with the scenario that artificially
forces use of the DLQ, it shouldn't remain untested
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
