liferoad commented on code in PR #26290: URL: https://github.com/apache/beam/pull/26290#discussion_r1218596628
########## sdks/python/apache_beam/transforms/timestamped_value_type_test.py: ########## @@ -0,0 +1,99 @@ +from apache_beam.typehints import Dict, Any, List +from apache_beam.typehints.decorators import TypeCheckError +from apache_beam.transforms.window import TimestampedValue + +import unittest +import apache_beam as beam + + +def ConvertToTimestampedValue(plant: Dict[str, Any]) -> TimestampedValue[str]: + return TimestampedValue[str](plant["name"], plant["season"]) + + +def ConvertToTimestampedValue_1(plant: Dict[str, Any]) -> TimestampedValue: + return TimestampedValue(plant["name"], plant["season"]) + + +def ConvertToTimestampedValue_2( + plant: Dict[str, Any]) -> TimestampedValue[List[str]]: Review Comment: Fixed. ########## sdks/python/apache_beam/transforms/window.py: ########## @@ -55,6 +55,8 @@ from typing import Iterable from typing import List from typing import Optional +from typing import Generic Review Comment: Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
