tvalentyn commented on code in PR #27052:
URL: https://github.com/apache/beam/pull/27052#discussion_r1222028134
##########
sdks/python/apache_beam/runners/dataflow/internal/apiclient_test.py:
##########
@@ -640,6 +640,25 @@ def
test_pinned_worker_harness_image_tag_used_in_dev_sdk(self):
# batch, legacy pipeline.
pipeline_options = PipelineOptions(
['--temp_location', 'gs://any-location/temp'])
+ env = apiclient.Environment(
+ [], #packages
+ pipeline_options,
+ '2.0.0', #any environment version
+ FAKE_PIPELINE_URL)
+ self.assertEqual(
+ env.proto.workerPools[0].workerHarnessContainerImage,
+ (
+ names.DATAFLOW_CONTAINER_IMAGE_REPOSITORY +
+ '/beam_python%d.%d_sdk:%s' % (
+ sys.version_info[0],
+ sys.version_info[1],
+ names.BEAM_FNAPI_CONTAINER_VERSION)))
+
+ pipeline_options = pipeline_options = PipelineOptions([
+ '--temp_location',
+ 'gs://any-location/temp',
+ '--experiments=disable_runner_v2'
Review Comment:
users now need to use disable_runner_v2_until_v2.50 , i disable_runner_v2
would fail on submission.
##########
sdks/python/apache_beam/runners/dataflow/internal/apiclient_test.py:
##########
@@ -710,6 +746,23 @@ def
test_worker_harness_image_tag_matches_base_sdk_version_of_an_rc(self):
# batch, legacy pipeline.
Review Comment:
misplaced comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
