johnjcasey commented on code in PR #27021:
URL: https://github.com/apache/beam/pull/27021#discussion_r1224580528
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerWriteSchemaTransformProvider.java:
##########
@@ -147,7 +180,7 @@ public PCollectionRowTuple expand(@NonNull
PCollectionRowTuple input) {
@Override
public @UnknownKeyFor @NonNull @Initialized List<@UnknownKeyFor @NonNull
@Initialized String>
outputCollectionNames() {
- return Collections.singletonList("failures");
+ return Arrays.asList("failures", "errors");
Review Comment:
we should use tupletags, not raw strings in general
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
