robertwb commented on code in PR #26922:
URL: https://github.com/apache/beam/pull/26922#discussion_r1224808670
##########
sdks/python/apache_beam/transforms/core.py:
##########
@@ -2581,7 +2581,7 @@ def add_input_types(transform):
if pcoll.windowing.windowfn != GlobalWindows():
Review Comment:
We should probably make this stronger, i.e. prohibiting anything but the
default (global windows *and* no non-trivial triggering) windowing. IIRC,
pcoll.windowing.is_default() would solve this. I don't think the solution below
would give the expected output(emitting exactly once towards the beginning of a
pipeline the few values that were combined up to that point).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
