robertwb commented on code in PR #27096:
URL: https://github.com/apache/beam/pull/27096#discussion_r1227259588
##########
sdks/python/apache_beam/yaml/yaml_provider.py:
##########
@@ -59,7 +60,11 @@ def provided_transforms(self) -> Iterable[str]:
raise NotImplementedError(type(self))
def create_transform(
- self, typ: str, args: Mapping[str, Any]) -> beam.PTransform:
+ self,
+ typ: str,
+ args: Mapping[str, Any],
+ yaml_create_transform: Callable[[Mapping[str, Any]], beam.PTransform]
Review Comment:
FYI, I'm looking at refactoring this a bit (doing a re-write like how the
other "meta" transforms are handled, as this is a bit hacky.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
