pabloem commented on a change in pull request #12151:
URL: https://github.com/apache/beam/pull/12151#discussion_r463273363
##########
File path:
sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/services/SnowflakeStreamingServiceConfig.java
##########
@@ -20,26 +20,51 @@
import java.util.List;
import net.snowflake.ingest.SimpleIngestManager;
+/** Class for preparing configuration for streaming write. */
public class SnowflakeStreamingServiceConfig extends ServiceConfig {
- SimpleIngestManager ingestManager;
- List<String> filesList;
- String stagingBucketDir;
+ private SimpleIngestManager ingestManager;
+ private List<String> filesList;
+ private String stagingBucketDir;
Review comment:
should these attributes also be final?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
