ryucc commented on code in PR #27131:
URL: https://github.com/apache/beam/pull/27131#discussion_r1232773128
##########
runners/samza/src/main/java/org/apache/beam/runners/samza/runtime/PortableBundleManager.java:
##########
@@ -110,15 +112,22 @@ private void scheduleNextBundleCheck() {
@Override
public void tryStartBundle() {
- currentBundleElementCount++;
+ currentBundleElementCount.incrementAndGet();
Review Comment:
On the failure case moving to the end would change from
"increment then reset" to only "reset"
It might reduce the number of race conditions possible, since it is 1 less
state change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
