damccorm commented on code in PR #26846:
URL: https://github.com/apache/beam/pull/26846#discussion_r1237190571
##########
build.gradle.kts:
##########
@@ -469,6 +469,16 @@ tasks.register("pythonPreCommit") {
dependsOn(":sdks:python:test-suites:tox:py311:preCommitPy311")
}
+tasks.register("pythonNotebooksPreCommit") {
+ /* doLast {
+ exec {
+ executable("sh")
+ args ("-c", ". ${envdir}/bin/activate && python -m
apache_beam.examples.wordcount --runner DirectRunner --output /tmp/output.txt")
+ }
+ }*/
+ dependsOn(":sdks:python:wordCount")
Review Comment:
This seems wrong - this should be depending on a task in
`:examples:notebooks`, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
