chamikaramj commented on code in PR #27146:
URL: https://github.com/apache/beam/pull/27146#discussion_r1240945578
##########
sdks/python/apache_beam/io/gcp/bigtableio.py:
##########
@@ -268,3 +272,95 @@ def process(self, row):
partial_row.cells[fam_name][col_qualifier_bytes].append(
Cell(value, timestamp_micros))
yield partial_row
+
+
+class WriteToBigtableXlang(beam.PTransform):
Review Comment:
Ah, that's confusing. How about following ?
Introduce a keyword argument "use_cross_language" to the constructor of
WriteToBigTable. If this is set to True, use your implementation underneath (in
the composite) instead of the existing implementation. For now leave the
default value of the property to "False" to that any existing users do not run
into surprises.
In the future, we should change the default value of this property to "True"
and may be also deprecate the existing Python version (after a discussion in
the dev list).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]