sjvanrossum commented on PR #27232: URL: https://github.com/apache/beam/pull/27232#issuecomment-1608051088
> Thanks, please take a look on my comments. > > I checked locally (macOS) `:sdks:java:extensions:avro:test` against `master` and passed with no failures. Did you run it with your changes or not? > > Also, we actually wanted to remove this plugin at all and generate Avro classes in teh way like we do here for multiple Avro versions checks: > > https://github.com/apache/beam/blob/a4281d8f35cf26bc62444f06b48d0019085e8e64/sdks/java/extensions/avro/build.gradle#L135 On my local machine I tried both. I just spun up a few containers using gradle:7.5.1-jdk* (8/11/17) and this consistently failed on JDK 11 and JDK 17, but runs fine on JDK 8. I wanted to test the safest possible version number, but I've just bumped this to 0.16.0 and it still works fine. The issue with 0.11.0 seems to have been resolved and the artifacts are available on https://plugins.gradle.org/m2/ again, so I'm not sure if this change is still relevant. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
