tvalentyn commented on code in PR #25965:
URL: https://github.com/apache/beam/pull/25965#discussion_r1245549269
##########
sdks/python/apache_beam/runners/portability/sdk_container_builder.py:
##########
@@ -307,16 +306,16 @@ def _invoke_docker_build_and_push(self,
container_image_name):
"Python SDK container built and pushed as %s." % container_image_name)
def _upload_to_gcs(self, local_file_path, gcs_location):
- gcs_bucket, gcs_object = self._get_gcs_bucket_and_name(gcs_location)
- request = storage.StorageObjectsInsertRequest(
- bucket=gcs_bucket, name=gcs_object)
+ bucket_name, blob_name = self._get_gcs_bucket_and_name(gcs_location)
_LOGGER.info('Starting GCS upload to %s...', gcs_location)
- total_size = os.path.getsize(local_file_path)
from apitools.base.py import exceptions
+ from google.cloud import storage
Review Comment:
ok. up to you, if tests pass, I am ok to proceed as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
