rohdesamuel commented on code in PR #27280:
URL: https://github.com/apache/beam/pull/27280#discussion_r1245578291
##########
sdks/python/apache_beam/runners/worker/data_sampler.py:
##########
@@ -136,6 +179,13 @@ def sample(self) -> None:
self.element_sampler.has_element = False
self._samples.append(self.element_sampler.el)
+ def sample_exception(
+ self, el: Any, exn: BaseException, transform_id: str,
+ instruction_id: str) -> None:
+ """Adds the given exception to the samples."""
+ self._exceptions.append(
Review Comment:
TODO: use the _samples_lock here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
