George-Wu commented on a change in pull request #12331:
URL: https://github.com/apache/beam/pull/12331#discussion_r463383155
##########
File path: sdks/python/apache_beam/io/gcp/dicomio.py
##########
@@ -164,70 +167,109 @@ class DicomSearch(PTransform):
}
"""
- def __init__(self, credential=None):
+ def __init__(self, buffer_size=8, max_workers=5, credential=None):
"""Initializes DicomSearch.
Args:
credential: # type: Google credential object, if it is specified, the
Http client will use it to create sessions instead of the default.
"""
+ self.buffer_size = buffer_size
+ self.max_workers = max_workers
Review comment:
Added, but for some objects reference issues in the unit test, it has to
be added in an ugly way in the WriteToDicomStore connector...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
