scwhittle commented on code in PR #27308:
URL: https://github.com/apache/beam/pull/27308#discussion_r1247290058
##########
sdks/java/harness/src/test/java/org/apache/beam/fn/harness/logging/BeamFnLoggingClientTest.java:
##########
@@ -249,7 +251,7 @@ public StreamObserver<BeamFnApi.LogEntry.List> logging(
StreamObserver<BeamFnApi.LogControl> outboundObserver) {
// Block before returning an error on the stream so that
we can observe the
// loggers before they are reset.
- streamBlocker.awaitAdvance(1);
Review Comment:
this should have been awaitAdvance(0) to have effect. Replaced with
CompletableFuture which is simpler for this single block and then trigger.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
