tvalentyn commented on code in PR #27236:
URL: https://github.com/apache/beam/pull/27236#discussion_r1248298867
##########
sdks/python/container/piputil.go:
##########
@@ -50,8 +38,8 @@ func pipInstallRequirements(files []string, dir, name string)
error {
// option will make sure that only things staged in the
worker will be
// used without following their dependencies.
args := []string{"-m", "pip", "install", "-r",
filepath.Join(dir, name), "--no-cache-dir", "--disable-pip-version-check",
"--no-index", "--no-deps", "--find-links", dir}
- pythonVersion := pythonVersion()
- if pythonVersion != "" {
+ pythonVersion,err := expansionx.getPythonVersion()
+ if err == nil {
Review Comment:
we need to fail with a clear error otherwise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
