ahmedabu98 commented on code in PR #26889:
URL: https://github.com/apache/beam/pull/26889#discussion_r1254948440
##########
sdks/python/apache_beam/examples/snippets/snippets.py:
##########
@@ -1181,6 +1189,32 @@ def model_bigqueryio(
create_disposition=beam.io.BigQueryDisposition.CREATE_IF_NEEDED)
# [END model_bigqueryio_write]
+ # [START model_bigqueryio_write_with_storage_write_api]
+ quotes | beam.io.WriteToBigQuery(
+ table_spec,
+ schema=table_schema,
+ method=beam.io.WriteToBigQuery.Method.STORAGE_WRITE_API)
+ # [END model_bigqueryio_write_with_storage_write_api]
Review Comment:
Thanks for looking into this @HaeSe0ng!
@Abacn do you know if it's sufficient for us to include the line
`LogicalType.register_logical_type(MillisInstant)` in the connector? e.g. here:
https://github.com/apache/beam/blob/7eaef18bcbfb48fb112884564b1362f638fe5834/sdks/python/apache_beam/io/gcp/bigquery.py#L2193-L2194
Or will we have to tell users to add this line themselves?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
