leiyiz commented on a change in pull request #12427: URL: https://github.com/apache/beam/pull/12427#discussion_r464038357
########## File path: sdks/python/apache_beam/testing/benchmarks/nexmark/queries/winning_bids.py ########## @@ -0,0 +1,183 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +from __future__ import absolute_import + +import apache_beam as beam +from apache_beam.coders import coder_impl +from apache_beam.coders.coders import FastCoder +from apache_beam.transforms.window import WindowFn +from apache_beam.transforms.window import IntervalWindow +from apache_beam.testing.benchmarks.nexmark.models import nexmark_model +from apache_beam.testing.benchmarks.nexmark.models import auction_bid +from apache_beam.testing.benchmarks.nexmark.queries import nexmark_query_util + + +class AuctionOrBidWindow(IntervalWindow): + """Windows for open auctions and bids.""" + def __init__(self, start, end, auction_id, is_auction_window): + super(AuctionOrBidWindow, self).__init__(start, end) + self.auction = auction_id + self.is_auction_window = is_auction_window + + @staticmethod + def for_auction(timestamp, auction: nexmark_model.Auction): + return AuctionOrBidWindow(timestamp, auction.expires, auction.id, True) + + @staticmethod + def for_bid(expected_duration_micro, timestamp, bid: nexmark_model.Bid): + return AuctionOrBidWindow( + timestamp, timestamp + expected_duration_micro * 2, bid.auction, False) + + def is_auction_window_fn(self): Review comment: I think it is fine to directly access the is_auciton_window field ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
