Abacn commented on code in PR #26193:
URL: https://github.com/apache/beam/pull/26193#discussion_r1258727258
##########
runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkPortableRunnerResult.java:
##########
@@ -44,13 +50,44 @@ public JobApi.MetricResults portableMetrics() throws
UnsupportedOperationExcepti
.build();
}
- static class Detached extends FlinkDetachedRunnerResult implements
PortablePipelineResult {
+ static class Detached implements PortablePipelineResult {
+
+ Detached() {
+ super();
+ }
@Override
public JobApi.MetricResults portableMetrics() throws
UnsupportedOperationException {
LOG.warn(
"Collecting monitoring infos is not implemented yet in Flink
portable runner (detached mode).");
return JobApi.MetricResults.newBuilder().build();
}
+
+ @Override
+ public @UnknownKeyFor @NonNull @Initialized State getState() {
Review Comment:
These "@UnknownKeyFor @NonNull @Initialized" are not necessary. These are
added by default to compiled .class. IDE may auto propagated them which is
slightly annoying.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
