mxm commented on pull request #12385:
URL: https://github.com/apache/beam/pull/12385#issuecomment-667895488
Thanks for fixing the quoting issue!
> I got `flinkCompatibilityMatrixPROCESS` to pass on my machine by escaping
the arguments via `${1@Q}`. Apparently whatever shell Jenkins is using does not
support this. I will have to find a better solution.
I think that feature only works in newer versions of `bash`.
> why do we need `flinkCompatibilityMatrixPROCESS` in the first place, when
it is not being run anywhere? If it's important, shouldn't we add it to some
postcommit?
`flinkCompatibilityMatrixPROCESS` was how we ran the PVR tests to avoid a
dependency on the container build (for speed). I was under the assumption that
we are still doing that. That probably changed when we added the external
transform tests which require the Java container. I agree that we should at
least have a post commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
