tvalentyn commented on code in PR #27429: URL: https://github.com/apache/beam/pull/27429#discussion_r1258984041
########## sdks/python/apache_beam/ml/inference/vertex_ai_inference.py: ########## @@ -41,6 +41,22 @@ # pylint: disable=line-too-long +def retry_on_gcp_client_error(exception): Review Comment: nit: prepend with `_` e.g. (`_is_gcp_client_error`) as this is an internal helper. Alternatively, could also inline this function via a `lambda` & include the rationale in the PR (no strong opinion here). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
