mkhludnev commented on code in PR #27406:
URL: https://github.com/apache/beam/pull/27406#discussion_r1259990781
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/logicaltypes/FixedPrecisionNumeric.java:
##########
@@ -113,4 +115,13 @@ public BigDecimal toInputType(BigDecimal base) {
}
return base;
}
+
+ /**
+ * @TODO is byte or fixed?
+ * @TODO should is pass namespace/field name, etc?
+ * */
+ public org.apache.avro.Schema toAvroType() {
Review Comment:
Fair. It needs to access `precision, scale)` which are private, yet, with no
getters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
