kennknowles commented on code in PR #27416:
URL: https://github.com/apache/beam/pull/27416#discussion_r1261220728
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/util/NoopLock.java:
##########
@@ -56,16 +54,15 @@ public boolean tryLock() {
}
@Override
- public boolean tryLock(long time, @Nonnull TimeUnit unit) {
+ public boolean tryLock(long time, @NonNull TimeUnit unit) {
Review Comment:
Remove the annotation, then. If checkerframework says it is unsafe, then it
is unsafe and you'll have to make it nullable and do any explicit check and
throw illegalargumentexception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
