riteshghorse commented on code in PR #27517:
URL: https://github.com/apache/beam/pull/27517#discussion_r1265721250
##########
sdks/python/apache_beam/ml/transforms/tft_test.py:
##########
@@ -353,7 +371,7 @@ def setUp(self) -> None:
def tearDown(self):
shutil.rmtree(self.artifact_location)
- def test_tfidf_batched_compute_vocab_size_during_runtime(self):
+ def test_tfidf__compute_vocab_size_during_runtime(self):
Review Comment:
```suggestion
def test_tfidf_compute_vocab_size_during_runtime(self):
```
##########
sdks/python/apache_beam/ml/transforms/tft_test.py:
##########
@@ -313,17 +289,17 @@ def
test_compute_and_apply_vocabulary_unbatched_inputs(self):
assert_that(actual_data, equal_to(expected_data))
- def test_compute_and_apply_vocabulary_batched(self):
- batch_size = 100
- num_instances = batch_size + 1
+ def test_compute_and_apply_vocabulary_(self):
Review Comment:
```suggestion
def test_compute_and_apply_vocabulary(self):
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
