lostluck opened a new issue, #27547: URL: https://github.com/apache/beam/issues/27547
### What needs to happen? The tests rely on overriding the GCP FHIR client with a test interface double, however, it hasn't been done in a serializable form, relying on the Direct Runner to not serialize the DoFns. eg. https://github.com/apache/beam/blob/master/sdks/go/pkg/beam/io/fhirio/deidentify.go#L85 https://github.com/apache/beam/blob/master/sdks/go/pkg/beam/io/fhirio/common.go#L205 This is not a good testing style as it isn't possible to execute them on portable runners, like prism, flink, spark, dataflow etc. Since this requires a bit more thought and code to resolve, fhirio will continue to use the direct runner as the default for now, but should be changed to an alternative testing means (possibly by a local GRPC connection or similar to a local fake of the service, setting the client endpoint to be overridden, with an API dialing option at client creation https://pkg.go.dev/google.golang.org/api/option#WithEndpoint) ### Issue Priority Priority: 3 (nice-to-have improvement) ### Issue Components - [ ] Component: Python SDK - [ ] Component: Java SDK - [X] Component: Go SDK - [ ] Component: Typescript SDK - [X] Component: IO connector - [ ] Component: Beam examples - [ ] Component: Beam playground - [ ] Component: Beam katas - [ ] Component: Website - [ ] Component: Spark Runner - [ ] Component: Flink Runner - [ ] Component: Samza Runner - [ ] Component: Twister2 Runner - [ ] Component: Hazelcast Jet Runner - [ ] Component: Google Cloud Dataflow Runner -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
