mosche commented on PR #27534: URL: https://github.com/apache/beam/pull/27534#issuecomment-1645513915
@bvolpato You're right, there's no dedicated tests for FromRowUsingCreator. However, test coverage is fairly decent by the subclasses mentioned above. Though, I just noticed protobuf, thrift & avro tests are not triggered as part of the precommit tests and looks like there's only a trigger phrase for avro :/ That's certainly a blocker. The other thing I've noticed during the implementation is that some features are not supported by all schemas, e.g. oneof / union types don't work with Avro. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
