tvalentyn commented on code in PR #27633:
URL: https://github.com/apache/beam/pull/27633#discussion_r1272475641


##########
sdks/python/apache_beam/typehints/native_type_compatibility_test.py:
##########
@@ -49,6 +49,11 @@ class _TestGeneric(typing.Generic[T]):
   pass
 
 
+class _TestPair(typing.NamedTuple('DataPair', [('base', T), ('diff', T)]),

Review Comment:
   please select some generic values for the stub to avoid unnecessary 
association with domain-specific code where the snippet came from.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to