Ruwann commented on PR #27621: URL: https://github.com/apache/beam/pull/27621#issuecomment-1648471965
I think it was a mistake when adding the `reverse` argument, based on the following commit: https://github.com/apache/beam/commit/866a09d6c5c4c1c3c39d3a1f2e7b4cb7ec319f6f#diff-c939f20e41fc848a26c5c8435fb348f118e81d9ced53dec490c1e5720a1be339L215 I can add a note in changes.md, although I'm not sure where's the best place: in theory, it's a potentially breaking if anyone is calling that function with that argument (even though it doesn't do anything) but that feels a bit heavy for this change. Wdyt? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
