lukecwik commented on a change in pull request #12419:
URL: https://github.com/apache/beam/pull/12419#discussion_r464699645
##########
File path:
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java
##########
@@ -1193,6 +1328,7 @@ public Object restriction() {
.setElement(bytesOut.toByteString());
// We don't want to change the output watermarks or set the checkpoint
resume time since
// that applies to the current window.
+ // TODO: Consider using currentWatermark in unprocessed window?
Review comment:
resolved since this suggestion was not optimal.
##########
File path:
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java
##########
@@ -1193,6 +1328,7 @@ public Object restriction() {
.setElement(bytesOut.toByteString());
// We don't want to change the output watermarks or set the checkpoint
resume time since
// that applies to the current window.
+ // TODO: Consider using currentWatermark in unprocessed window?
Review comment:
resolved since this suggestion was not right.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
