tvalentyn commented on code in PR #27646:
URL: https://github.com/apache/beam/pull/27646#discussion_r1274215622
##########
sdks/python/apache_beam/transforms/util_test.py:
##########
@@ -1041,6 +1042,23 @@ def test_output_typehints(self):
ShardedKeyType[typehints.Tuple[int, int]], # type: ignore[misc]
typehints.Iterable[str]])
+ def test_with_type_hints(self):
+ options = PipelineOptions()
+ options.view_as(TypeOptions).runtime_type_check = True
+ with TestPipeline(options=options) as pipeline:
+ collection = pipeline \
Review Comment:
nit / personal opinion: you can use brackets instead of line continuation
tokens
##########
sdks/python/apache_beam/transforms/util_test.py:
##########
@@ -1041,6 +1042,23 @@ def test_output_typehints(self):
ShardedKeyType[typehints.Tuple[int, int]], # type: ignore[misc]
typehints.Iterable[str]])
+ def test_with_type_hints(self):
Review Comment:
`test_runtime_type_check` might be a better name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
