AnandInguva opened a new pull request, #26307:
URL: https://github.com/apache/beam/pull/26307
Context
* Directly calling setup.py for installing the Python package is deprecated.
python setup.py install will throw a warning:
```
SetuptoolsDeprecationWarning: setup.py install is deprecated.
Use build and pip and other standards-based tools.
```
* The new replacement for setup.py is PEP 517 and PEP 621.
* PEP 621: The package's metadata is now specified in pyproject.toml.
The TOML file is declarative and cannot contain arbitrary code unlike setup.py.
This PR provides
1. Replace `setup.py sdist` with [build](https://pypi.org/project/build/).
This will install the build dependencies in an isolated environments and then
generates sdist. Setuptools itself strongly suggests using this and to avoid
using `setup.py sdist` since it is treated as deprecated. You can find more at
https://github.com/pypa/setuptools/blob/245d72a8aa4d47e1811425213aba2a06a0bb64fa/docs/deprecated/commands.rst#L10
* Modify the CI to build the sdist with `python -m build`
2. Remove the `build-requirements.txt` since we move those dependencies into
`pyproject.toml`.
3. Remove the code in `gen_protos.py` where we install `build dependencies`.
This is not required now since editable and sdist installation will install the
build dependencies at the very beginning.
TODO:
* Remove the `apache_beam/testing` from the sdist generation
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example:
`addresses #123`), if applicable. This will automatically add a link to the
pull request in the issue. If you would like the issue to automatically close
on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more
tips on [how to make review process
smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit
[https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more
information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
