AnandInguva commented on code in PR #27436:
URL: https://github.com/apache/beam/pull/27436#discussion_r1275667763


##########
sdks/python/container/boot.go:
##########
@@ -371,6 +371,16 @@ func installSetupPackages(files []string, workDir string, 
requirementsFiles []st
                log.Printf("Failed to setup acceptable wheel specs, leave it as 
empty: %v", err)
        }
 
+       pkgName := "apache-beam"
+       isSdkInstalled, err := isPackageInstalled(pkgName)
+       if err != nil {
+               return fmt.Errorf("failed to check if Apache Beam %s is 
installed: %v", pkgName, err)

Review Comment:
   I removed this entirely.



##########
sdks/python/container/boot.go:
##########
@@ -371,6 +371,16 @@ func installSetupPackages(files []string, workDir string, 
requirementsFiles []st
                log.Printf("Failed to setup acceptable wheel specs, leave it as 
empty: %v", err)
        }
 
+       pkgName := "apache-beam"
+       isSdkInstalled, err := isPackageInstalled(pkgName)
+       if err != nil {
+               return fmt.Errorf("failed to check if Apache Beam %s is 
installed: %v", pkgName, err)
+       }
+
+       if !isSdkInstalled {
+               log.Printf("Apache Beam is not installed on the custom 
container. Please make sure Apache Beam is installed in the custom container. 
Look at the docummentation 
https://beam.apache.org/documentation/runtime/environments/ on custom 
containers for more details.")

Review Comment:
   Changed wording



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to